Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3414

#include <pwd.h> in THeaderTransport.h breaks windows build

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.10.0
    • 0.10.0
    • C++ - Library
    • None
    • Visual Studio 2013

    • Patch Available
    • Patch

    Description

      The #include <pwd.h> in THeaderTransport.h breaks windows build, because it doesn't have a pwd.h.

      When removing the header I don't see any errors neither on Windows nor on Linux (GCC).

      I think the file is not needed at all. The attached patch removes it.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            pascal.bach Pascal Bach
            pascal.bach Pascal Bach
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment