Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3414

#include <pwd.h> in THeaderTransport.h breaks windows build

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: C++ - Library
    • Labels:
      None
    • Environment:

      Visual Studio 2013

    • Patch Info:
      Patch Available
    • Flags:
      Patch

      Description

      The #include <pwd.h> in THeaderTransport.h breaks windows build, because it doesn't have a pwd.h.

      When removing the header I don't see any errors neither on Windows nor on Linux (GCC).

      I think the file is not needed at all. The attached patch removes it.

        Attachments

        1. remove_pwd_h.patch
          0.4 kB
          Pascal Bach

          Activity

            People

            • Assignee:
              pascal.bach Pascal Bach
              Reporter:
              pascal.bach Pascal Bach
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: