Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3395

Cocoa compiler produces corrupt code when boxing enums inside map.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.10.0
    • Cocoa - Compiler
    • None
    • Patch Available

    Description

      Essentially fix for https://issues.apache.org/jira/browse/THRIFT-2905 and PR #652.
      Given something like this:

      void someRpcCall(1:map<SomeEnum, AnotherEnum> param);
      

      Cocoa compiler produces corrupt implementation.

      - (BOOL) someRpcCall:(NSDictionary< , > *) param error: (NSError *__autoreleasing *)__thriftError;
      

      This fixes it so code rendered properly, boxing enums into NSNumber*.

      Attachments

        Issue Links

          Activity

            People

              skeeet Aleksei Shevchenko
              skeeet Aleksei Shevchenko
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: