[THRIFT-3321] Thrift can't be added as a subdirectory of another CMake-based project

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Build Process
• Labels: cmake
• Flags: Patch
• Assignee: Roger Meier
• Reporter: Frane Šarić
• Created: 10/Sep/15 20:59
• Updated: 04/Apr/16 18:52
• Resolved: 04/Apr/16 18:52

Description

I wanted my CMake-based project to build thrift as a dependency, so I added the following to my CMakeLists.txt:

set(BUILD_COMPILER OFF CACHE BOOL "")
set(BUILD_TESTING OFF CACHE BOOL "")
set(BUILD_EXAMPLES OFF CACHE BOOL "")
set(BUILD_TUTORIALS OFF CACHE BOOL "")
set(BUILD_LIBRARIES ON CACHE BOOL "")
set(BUILD_C_GLIB OFF CACHE BOOL "")
set(BUILD_JAVA OFF CACHE BOOL "")
set(BUILD_PYTHON OFF CACHE BOOL "")
add_subdirectory(thrift)

The build process fails because build/cmake/CPackConfig.cmake fails to find README.md and LICENSE files. It fails to find them because it uses CMAKE_SOURCE_DIR instead of CMAKE_CURRENT_SOURCE_DIR. After changing CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR everything works as expected.