[THRIFT-3315] send_ and recv_ methods collide with thrift-defined methods

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Node.js - Compiler
• Assignee: Unassigned
• Reporter: Matt Fysh
• Created: 04/Sep/15 03:13
• Updated: 09/Sep/15 23:15

Description

a.thrift

service Test {
	i32 a()
	i32 recv_a()
}

$ thrift -r --gen js:node a.thrift

gen-nodejs/Test.js

// ...
TestClient.prototype.recv_a = function(input,mtype,rseqid) {
// ...
TestClient.prototype.recv_a = function(callback) {
// ...

Possible solutions:
1) throw an error if collisions detected during generation
2) prefix the private methods with an underscore for private namespacing, i.e. _recv_a and _send_a