[THRIFT-3302] Go JSON protocol should encode Thrift byte type as signed integer string

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: Go - Library
• Patch Info: Patch Available
• Assignee: Nobuaki Sukegawa
• Reporter: Nobuaki Sukegawa
• Created: 23/Aug/15 06:31
• Updated: 15/Sep/15 19:53
• Resolved: 05/Sep/15 11:16

Description

Problem

Go implementation of JSON and simple JSON protocols encode Thrift byte type field as unsigned 8bit integer.

i.e. -1 is encoded to "255" by Go implementation while "-1" by others like C++, Java and Python.

Reproduce

Cross test with go server and py client (JSON protocols of course).
(like "expected -127 but got 129")

Static-typed clients (such as C++ and Java) are not likely to notice the difference because of integer overflow.

Fix

Explicitly convert the unsigned 8-bit value back to signed one in JSON protocols before converting to text.