[THRIFT-3301] Java generated code uses imports that can lead to class name collisions with IDL defined types

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8, 0.9, 0.9.1, 0.9.2
• Fix Version/s: 0.10.0
• Component/s: Java - Compiler

Environment

Tested on Linux (Ubuntu 14) with Oracle JDK 8

• Assignee: Benjamin Gould
• Reporter: Alexander Volanis
• Created: 20/Aug/15 15:45
• Updated: 12/Dec/16 18:02
• Resolved: 03/Dec/16 00:04

Description

The Java generator will produce Java classes with the following set of imports

import org.apache.thrift.scheme.IScheme;
import org.apache.thrift.scheme.SchemeFactory;
import org.apache.thrift.scheme.StandardScheme;

import org.apache.thrift.scheme.TupleScheme;
import org.apache.thrift.protocol.TTupleProtocol;
import java.util.List;
import java.util.ArrayList;
import java.util.Map;
import java.util.HashMap;
import java.util.EnumMap;
import java.util.Set;
import java.util.HashSet;
import java.util.EnumSet;
import java.util.Collections;
import java.util.BitSet;
import java.nio.ByteBuffer;
import java.util.Arrays;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Any one of the imported classes may cause a name conflict with generated code that happens to define a same name class and uses such class as argument or result to methods.

The generated code should always use fully qualified references to the classes when necessary and avoid all use of imports.

Issue Links

• is related to: THRIFT-3954 Enable the usage of structs called "Object" in Java
• relates to: THRIFT-3954 Enable the usage of structs called "Object" in Java
• links to: GitHub Pull Request #1119
• links to: GitHub Pull Request #1120