[THRIFT-3293] JavaScript: null values turn into empty structs in constructor

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: JavaScript - Compiler, Node.js - Compiler
• Patch Info: Patch Available
• Assignee: Henrique Mendonca
• Reporter: Håkon Hitland
• Created: 12/Aug/15 17:21
• Updated: 25/Aug/15 04:44
• Resolved: 17/Aug/15 11:48

Description

Given a struct definition with an optional struct field, e.g.

struct Foo {
  1: Bar bar,
}

Trying to initialize it to a null value like

new Foo({"bar": null});

will instead set bar to an empty Bar object.

This happens because the constructor tests for undefined values, but not for null.

In addition to direct user calls, the internal copyList and copyMap functions introduced for THRIFT-3122 now often trigger this by initializing one object from another, making it hard to work around.