[THRIFT-3266] c_glib: Multiple compiler warnings building unit tests

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: C glib - Library
• Labels: c_glib

Environment

Fedora 20 (gcc 4.8.3) on x86_64

• Patch Info: Patch Available
• Flags: Patch
• Assignee: Simon South
• Reporter: Simon South
• Created: 25/Jul/15 01:05
• Updated: 20/Feb/21 15:27
• Resolved: 28/Jul/15 21:56

Description

Building the unit tests for C (GLib) (under lib/c_glib/test) generates a lot of compiler warnings:

gen-c_glib/t_test_debug_proto_test_types.c:16496:1: warning: 't_test_compact_test_constant' defined but not used [-Wunused-function]
 t_test_compact_test_constant (void)
 ^
gen-c_glib/t_test_debug_proto_test_types.c:16596:1: warning: 't_test_my_enum_map_constant' defined but not used [-Wunused-function]
 t_test_my_enum_map_constant (void)
 ^
gen-c_glib/t_test_debug_proto_test_types.c:16608:1: warning: 't_test_extra_crazy_map_constant' defined but not used [-Wunused-function]
 t_test_extra_crazy_map_constant (void)
 ^
testtransportsocket.c: In function ‘main’:
testtransportsocket.c:313:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
testbinaryprotocol.c: In function ‘test_read_and_write_primitives’:
testbinaryprotocol.c:195:5: warning: implicit declaration of function ‘wait’ [-Wimplicit-function-declaration]
     assert (wait (&status) == pid);
     ^
testbinaryprotocol.c: In function ‘main’:
testbinaryprotocol.c:663:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
testbufferedtransport.c: In function ‘test_read_and_write’:
testbufferedtransport.c:154:5: warning: implicit declaration of function ‘wait’ [-Wimplicit-function-declaration]
     assert ( wait (&status) == pid );
     ^
testbufferedtransport.c: In function ‘main’:
testbufferedtransport.c:276:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
testframedtransport.c: In function ‘test_read_and_write’:
testframedtransport.c:142:5: warning: implicit declaration of function ‘wait’ [-Wimplicit-function-declaration]
     assert ( wait (&status) == pid );
     ^
testframedtransport.c: In function ‘main’:
testframedtransport.c:274:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
testmemorybuffer.c: In function ‘main’:
testmemorybuffer.c:87:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
teststruct.c: In function ‘main’:
teststruct.c:95:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
testsimpleserver.c: In function ‘main’:
testsimpleserver.c:109:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
testoptionalrequired.c: In function ‘main’:
testoptionalrequired.c:193:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
testthrifttest.c: In function ‘main’:
testthrifttest.c:22:3: warning: ‘g_type_init’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init();
   ^
testthrifttest.c:25:3: warning: passing argument 2 of ‘g_test_add_func’ from incompatible pointer type [enabled by default]
   g_test_add_func ("/testthrift/Server", test_thrift_server);
   ^
In file included from /usr/include/glib-2.0/glib.h:84:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:30,
                 from /usr/include/glib-2.0/glib-object.h:25,
                 from ../src/thrift/c_glib/transport/thrift_server_transport.h:23,
                 from testthrifttest.c:4:
/usr/include/glib-2.0/glib/gtestutils.h:128:9: note: expected ‘GTestFunc’ but argument is of type ‘void (*)(const int)’
 void    g_test_add_func                 (const char     *testpath,
         ^
testthrifttestclient.cpp: In function ‘void test_thrift_client()’:
testthrifttestclient.cpp:358:3: warning: ‘void g_type_init()’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init ();
   ^
testthrifttestclient.cpp:358:16: warning: ‘void g_type_init()’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
   g_type_init ();
                ^

Issue Links

• depends upon: THRIFT-2917 "make clean" breaks test/c_glib
• relates to: THRIFT-3260 multiple warnings in c_glib tutorial
• relates to: THRIFT-3284 c_glib: Empty service produces unused-variable warning

Sub-Tasks

• c_glib tutorial warnings in generated code: Closed