Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3248

TypeScript: additional comma in method signature without parameters

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9.2
    • 0.9.3
    • JavaScript - Compiler
    • Patch Available
    • Patch, Important

    Description

      The generated TypeScript code has an issue with methods with no parameters. The method signature shows an additional comma character (',') in the parameter list which have a callback argument.

        /**
         * A method definition....
         */
        ping(): void;
      
        /**
         * A method definition....
         */
        ping(, callback: Function): JQueryXHR;
      

      Attachments

        Activity

          roger Roger Meier added a comment -

          committed

          roger Roger Meier added a comment - committed
          hudson Hudson added a comment -

          SUCCESS: Integrated in Thrift #1614 (See https://builds.apache.org/job/Thrift/1614/)
          THRIFT-3248 Remove additional comma in TypeScript method signature (r.meier: rev 8b01553758365b34eab45f42cdf4934daa85f39a)

          • compiler/cpp/src/generate/t_js_generator.cc
          hudson Hudson added a comment - SUCCESS: Integrated in Thrift #1614 (See https://builds.apache.org/job/Thrift/1614/ ) THRIFT-3248 Remove additional comma in TypeScript method signature (r.meier: rev 8b01553758365b34eab45f42cdf4934daa85f39a) compiler/cpp/src/generate/t_js_generator.cc

          People

            roger Roger Meier
            kfenner Kaspar Fenner
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: