[THRIFT-3164] Thrift C++ library SSL socket by default allows for unsecure SSLv3 negotiation

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.8, 0.9, 0.9.1, 0.9.2
• Fix Version/s: 0.9.3
• Component/s: C++ - Library
• Labels: SSL SSLSocketFactory Security
• Assignee: James E. King III
• Reporter: James E. King III
• Created: 19/May/15 04:35
• Updated: 25/Aug/15 04:44
• Resolved: 30/Jul/15 19:59

Description

The TSSLSocketFactory allows for both SSLv3 and TLSv1 handshake. SSLv3 is ancient and has a serious security flaw:
http://disablessl3.com/

Currently the project uses the following default (in TSSLSocket.h):

  /**
   * Constructor/Destructor
   *
   * @param protocol The SSL/TLS protocol to use.
   */
  TSSLSocketFactory(const SSLProtocol& protocol = SSLTLS);

also (same file:

/**
 * Wrap OpenSSL SSL_CTX into a class.
 */
class SSLContext {
public:
  SSLContext(const SSLProtocol& protocol = SSLTLS);

This enumeration maps to:

enum SSLProtocol {
  SSLTLS = 0, // Supports SSLv3 and TLSv1.
  // SSLv2		= 1,	// HORRIBLY INSECURE!
  SSLv3 = 2,   // Supports SSLv3 only.
  TLSv1_0 = 3, // Supports TLSv1_0 only.
  TLSv1_1 = 4, // Supports TLSv1_1 only.
  TLSv1_2 = 5  // Supports TLSv1_2 only.
};

Recommend changing the default/minimum in Thrift to TLSv1. Add a test to prove SSLv3 client cannot connect by default, and that TLSv1_0, _1, and _2 can all connect.

THRIFT-3165 takes the recommendation a step further and suggests the default should be TLS v1.2 or later, and the third party using Thrift can decide if they want to allow less-secure ciphers.

Issue Links

• is related to: THRIFT-151 TSSLServerSocket and TSSLSocket implementation
• relates to: THRIFT-3165 Disable unsafe TLSv1.0 and TLSv1.1 by default