Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3138

"make check" parallel execution is underministic

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Patch Available
    • Patch

    Description

      Some make tasks dependent on generated Thrift code occasionally fail.
      THRIFT-2971 fixed it for cpp but some languages' make check still have the problem, namely,
      c_glib, go and python.

      Command I used to reproduce the behavior locally:

      git clean -dfx && ./bootstrap.sh && ./configure --without-... && make check -j24
      

      It only fails occasionally and the failure location varies.

      An example of build failure log in case of c_glib:

      gen-c_glib/t_test_inherited.h:37:3: error: unknown type name ‘TTestSrvClient’
         TTestSrvClient parent;
         ^
      gen-c_glib/t_test_inherited.h:43:3: error: unknown type name ‘TTestSrvClientClass’
         TTestSrvClientClass parent;
         ^
      gen-c_glib/t_test_inherited.h:64:3: error: unknown type name ‘TTestSrvHandler’
         TTestSrvHandler parent;
         ^
      gen-c_glib/t_test_inherited.h:70:3: error: unknown type name ‘TTestSrvHandlerClass’
         TTestSrvHandlerClass parent;
         ^
      gen-c_glib/t_test_inherited.h:89:3: error: unknown type name ‘TTestSrvProcessor’
         TTestSrvProcessor parent;
         ^
      gen-c_glib/t_test_inherited.h:99:3: error: unknown type name ‘TTestSrvProcessorClass’
         TTestSrvProcessorClass parent;
         ^
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nsuke Nobuaki Sukegawa
            nsuke Nobuaki Sukegawa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment