Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3134

Remove use of deprecated "phantom.args"

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.9.3
    • None
    • NodeJS 0.12.2
      npm 2.9.0
      ArchLinux

    • Patch Available
    • Patch

    Description

      JS library test uses phantom.args which is deprecated at least since Oct 29, 2011[1] and removed from PhantomJS 2.

      Build log shows that the build system tries to find phantom 1.X but for some reason, in my environment, it uses phantom2 and the test fails.

      The failure may only be a configuration problem but removing use of deprecated API would be a good idea.

      [1] https://code.google.com/p/phantomjs/issues/detail?id=276

      Attachments

        Activity

          People

            nsuke Nobuaki Sukegawa
            nsuke Nobuaki Sukegawa
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: