[THRIFT-3134] Remove use of deprecated "phantom.args"

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: JavaScript - Library, Test Suite

Environment

NodeJS 0.12.2
npm 2.9.0
ArchLinux

• Patch Info: Patch Available
• Flags: Patch
• Assignee: Nobuaki Sukegawa
• Reporter: Nobuaki Sukegawa
• Created: 09/May/15 10:17
• Updated: 21/Jul/15 02:21
• Resolved: 10/May/15 16:30

Description

JS library test uses phantom.args which is deprecated at least since Oct 29, 2011[1] and removed from PhantomJS 2.

Build log shows that the build system tries to find phantom 1.X but for some reason, in my environment, it uses phantom2 and the test fails.

The failure may only be a configuration problem but removing use of deprecated API would be a good idea.

[1] https://code.google.com/p/phantomjs/issues/detail?id=276