[THRIFT-3098] Thrift does not pretty print binary typedefs the way it does binary fields

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.9.3
• Component/s: Java - Compiler
• Assignee: Jens Geyer
• Reporter: Roshan George
• Created: 16/Apr/15 04:39
• Updated: 30/Apr/15 18:57
• Resolved: 16/Apr/15 19:30

Description

The generated Java struct toString uses TBaseHelper.toString to print binary fields but not fields which are typedef binary.

e.g.

typedef BinType binary
struct BinHolder {
 1: binary bin_field
 2: BinType typedef_field
}

results in

 sb.append("bin_field:");
    if (this.bin_field == null) {
      sb.append("null");
    } else {
      org.apache.thrift.TBaseHelper.toString(this.bin_field, sb);
    }
    first = false;
    if (!first) sb.append(", ");
    sb.append("typedef_field:");
    if (this.typedef_field == null) {
      sb.append("null");
    } else {
      sb.append(this.typedef_field);
    }