[THRIFT-3093] mingw compile fixes for c++ library 0.9.2

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: C++ - Library

Environment

mingw/cygwin

• Patch Info: Patch Available
• Flags: Patch
• Assignee: Unassigned
• Reporter: Eion Robb
• Created: 13/Apr/15 03:02
• Updated: 21/Jul/15 02:21
• Resolved: 01/May/15 02:52

Description

I've spent the morning trying to get the C++ library compiled using mingw/cygwin. I had to make a few changes to get things to compile. Some places didn't include sys/time.h when they needed to (for the timeval struct) and I needed to make the timeval struct in the global namespace, else the compiler would try to look for it in the thrift namespace.

There was also a minor issue with the syntax for the #ifdef HAVE_STRERROR_R check in Thrift.cpp; the config.h file says to set the parameter to 0 if strerror_r is not available - rather than undefine it.

Last of all, I had to add in an implementation of vsnprintf() as my version of mingw did not provide it