Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3093

mingw compile fixes for c++ library 0.9.2

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Invalid
    • 0.9.2
    • 0.9.3
    • C++ - Library
    • None
    • mingw/cygwin

    • Patch Available
    • Patch

    Description

      I've spent the morning trying to get the C++ library compiled using mingw/cygwin. I had to make a few changes to get things to compile. Some places didn't include sys/time.h when they needed to (for the timeval struct) and I needed to make the timeval struct in the global namespace, else the compiler would try to look for it in the thrift namespace.

      There was also a minor issue with the syntax for the #ifdef HAVE_STRERROR_R check in Thrift.cpp; the config.h file says to set the parameter to 0 if strerror_r is not available - rather than undefine it.

      Last of all, I had to add in an implementation of vsnprintf() as my version of mingw did not provide it

      Attachments

        1. mingw-compile.diff
          3 kB
          Eion Robb

        Activity

          People

            Unassigned Unassigned
            eionrobb Eion Robb
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: