[THRIFT-3083] C++ Consolidate server processing loops in TSimpleServer, TThreadedServer, TThreadPoolServer

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8, 0.9, 0.9.1, 0.9.2
• Fix Version/s: 0.9.3
• Component/s: C++ - Library
• Assignee: James E. King III
• Reporter: James E. King III
• Created: 05/Apr/15 13:13
• Updated: 21/Jul/15 02:21
• Resolved: 04/May/15 13:40

Description

Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.

1. Add TServerFramework that implements serve() and stop() for TServer, but is abstract.

2. Add virtual methods onClientConnected, onClientDisconnected to TServerFramework and require subclasses to implement them.

3. TSimpleServer onClientConnected calls TConnectedClient().run() in the serve() thread, thus blocking the server thread until the client disconnects.

4. TThreadedServer::serve() calls TServerFramework::serve() and then waits for the notification that all clients are gone. ::onClientConnected adds a TConnectedClient to the task set and starts a thread for it. ::onClientDisconnected removes the client from the task set.

5. TThreadPoolServer would have similar changes.

The resulting classes will be much smaller, and the specific differences between the servers will be more obvious. Further, the server processing loop which is common to all three will be in one place. This improves the predictability of thrift and helps improve maintainability.

Issue Links

• blocks: THRIFT-3084 C++ add concurrent client limit to threaded servers
• is blocked by: THRIFT-3081 C++ Consolidate client processing loops in TServers
• is related to: THRIFT-1316 thrift: update server classes to accept
• relates to: THRIFT-3096 Consolidate TSimpleServer, TThreadedServer, TThreadPoolServer into one