Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3060

Node.js client retry logic doesn't flush offline queue on reconnect

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.9.2
    • 0.13.0
    • Node.js - Library
    • None
    • Patch Available

    Description

      The Node.js client includes retry logic in case the connection terminates unexpectedly. On reconnect, the `offline_queue` variable never gets reset, so any requests still in the queue will get processed on every reconnect.

      In addition, the variables the keep track of the retry state are not initialized prior to a successful connection, meaning that if the initial connection doesn't succeed, that the retry timer is set to `NaN` and doesn't work as expected.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jking3 James E. King III
            chris.thompson Chris Thompson
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment