[THRIFT-3043] go compiler generator uses non C++98 code

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.9.3
• Component/s: Go - Compiler
• Assignee: Jens Geyer
• Reporter: Randy Abernethy
• Created: 16/Mar/15 00:33
• Updated: 30/Mar/15 20:58
• Resolved: 16/Mar/15 22:41

Description

go compiler generator uses non C++98 code causing builds to fail in Centos 6 and other environments.

==> default: src/generate/t_go_generator.cc:415: error: in C++98 ���commonInitialisms��� must be initialized by constructor, not by ���

{...}

���
==> default: src/generate/t_go_generator.cc:415: error: deducing from brace-enclosed initializer list requires #include <initializer_list>
==> default: src/generate/t_go_generator.cc:415: error: deducing from brace-enclosed initializer list requires #include <initializer_list>
==> default: src/generate/t_go_generator.cc:415: warning: extended initializer lists only available with -std=c+0x or -std=gnu+0x
==> default: src/generate/t_go_generator.cc:415: error: no matching function for call to ���std::set<std::basic_string<char, std::char_traits<char>, s
td::allocator<char> >, std::less<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::basic_string<char, std:
:char_traits<char>, std::allocator<char> > > >::set(<brace-enclosed initializer list>)���
==> default: /usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../include/c++/4.4.7/bits/stl_set.h:188: note: candidates are: std::set<_Key, _Compare, _
Alloc>::set(const std::set<_Key, _Compare, _Alloc>&) [with _Key = std::basic_string<char, std::char_traits<char>, std::allocator<char> >, _Compare = s
td::less<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, _Alloc = std::allocator<std::basic_string<char, std::char_traits<ch
ar>, std::allocator<char> > >]
==> default: /usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../include/c++/4.4.7/bits/stl_set.h:136: note: std::set<_Key, _Compare, _
Alloc>::set() [with _Key = std::basic_string<char, std::char_traits<char>, std::allocator<char> >, _Compare = std::less<std::basic_string<char, std::c
har_traits<char>, std::allocator<char> > >, _Alloc = std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >]
==> default: make[3]: *** [thrift-t_go_generator.o] Error 1
==> default: make[3]: Leaving directory `/thrift/compiler/cpp'
==> default: make[2]: *** [all] Error 2

Issue Links

• is broken by: THRIFT-3027 Go compiler does not ensure common initialisms have consistent case