Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2976

nodejs: xhr and websocket support for browserify

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.9.3
    • Node.js - Library
    • None
    • Trusty64 Vagrant box

    • Patch Available

    Description

      The attached patch adds support for XHR connections and WebSocket connections in the browser. Currently there are only tests for XHR since phantomjs 1.x.x does not fully support the websockets protocol. Once phantom 2.x.x is released a test for websockets will be added. Currently only TJSONProtocol and TBufferedTransport are supported. More work needs to be done to get other protocols and transports to work.

      To make browser tests work, all tests were converted to substack/tape (which is a TAP testing harness that works both on the server and in the browser). This has the side effect of making the tests way more readable.

      Depends on the patches on these issues applied in this order:
      THRIFT-2932 - Node.js Thrift connection libraries throw Exceptions into event emitter
      THRIFT-2969 - nodejs: DRY up library tests
      THRIFT-2964 - nodejs: move protocols and transports into separate files

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            codesf Randy Abernethy
            andrewdeandrade Andrew de Andrade
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment