Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2957

warning: source file %s is in a subdirectory, but option 'subdir-objects' is disabled

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.9.3
    • Build Process
    • None
    • Ubuntu on EC2 and OS X on a Macbook Pro,
      openSUSE

    • Patch Available

    Description

      automake produces a lot of these errors and in the configure.ac file the line with AM_INIT_AUTOMAKE([...]) does not contain subdir-objects as an option.

      Attachments

        Activity

          automake produces a lot of these errors and in the configure.ac file the line with AM_INIT_AUTOMAKE([...]) does not contain subdir-objects as an option.

          andrewdeandrade Andrew de Andrade added a comment - automake produces a lot of these errors and in the configure.ac file the line with AM_INIT_AUTOMAKE( [...] ) does not contain subdir-objects as an option.
          jensg Jens Geyer added a comment -

          I can confirm that, I've seen that too. IIRC these messages are also logged into the CI logs.

          jensg Jens Geyer added a comment - I can confirm that, I've seen that too. IIRC these messages are also logged into the CI logs.

          Shall I submit a PR with the subdir-objects option added to configure.ac? I'm not familiar with autoconf, so I'm not certain that's the correct way to resolve this.

          andrewdeandrade Andrew de Andrade added a comment - Shall I submit a PR with the subdir-objects option added to configure.ac? I'm not familiar with autoconf, so I'm not certain that's the correct way to resolve this.
          simonsouth Simon South added a comment -

          Patch to configure.ac to prevent build warnings, errors when using automake 1.14

          simonsouth Simon South added a comment - Patch to configure.ac to prevent build warnings, errors when using automake 1.14
          simonsouth Simon South added a comment -

          I've gone ahead and added a patch that simply adds subdir-objects at the appropriate place in configure.ac. With this change I can build the latest code in the repository using automake 1.14.1-4 except that the file compiler/cpp/thrifty.cc isn't generated automatically by bison, which must be invoked manually. I'm investigating.

          simonsouth Simon South added a comment - I've gone ahead and added a patch that simply adds subdir-objects at the appropriate place in configure.ac . With this change I can build the latest code in the repository using automake 1.14.1-4 except that the file compiler/cpp/thrifty.cc isn't generated automatically by bison, which must be invoked manually. I'm investigating.
          simonsouth Simon South added a comment -

          Here's a second patch that updates the (expected) location of thrifty.cc.

          With both these patches applied I'm able to build Thrift using automake version 1.13.4 or 1.14.1 without error and without warnings from bootstrap.sh.

          simonsouth Simon South added a comment - Here's a second patch that updates the (expected) location of thrifty.cc . With both these patches applied I'm able to build Thrift using automake version 1.13.4 or 1.14.1 without error and without warnings from bootstrap.sh .
          jensg Jens Geyer added a comment -

          I give it a try. While trying, I will also send a PR with your code, just to see how Travis reacts. It's still your patch, so don't worry

          jensg Jens Geyer added a comment - I give it a try. While trying, I will also send a PR with your code, just to see how Travis reacts. It's still your patch, so don't worry
          githubbot ASF GitHub Bot added a comment -

          GitHub user Jens-G opened a pull request:

          https://github.com/apache/thrift/pull/563

          THRIFT-2957 warning: source file %s is in a subdirectory, but option …

          …'subdir-objects' is disabled

          Client: Compiler General
          Patch: Simon South

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Jens-G/thrift THRIFT-2957

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/thrift/pull/563.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #563


          commit b6cda377fe7d4f63afe5cae184b1840371f4011f
          Author: Jens Geyer <jensg@apache.org>
          Date: 2015-07-25T13:59:46Z

          THRIFT-2957 warning: source file %s is in a subdirectory, but option 'subdir-objects' is disabled
          Client: Compiler General
          Patch: Simon South


          githubbot ASF GitHub Bot added a comment - GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/563 THRIFT-2957 warning: source file %s is in a subdirectory, but option … …'subdir-objects' is disabled Client: Compiler General Patch: Simon South You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-2957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/563.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #563 commit b6cda377fe7d4f63afe5cae184b1840371f4011f Author: Jens Geyer <jensg@apache.org> Date: 2015-07-25T13:59:46Z THRIFT-2957 warning: source file %s is in a subdirectory, but option 'subdir-objects' is disabled Client: Compiler General Patch: Simon South
          jensg Jens Geyer added a comment -

          3 builds failed on Travis, all with the same error:

          make  check-recursive
          make[4]: Entering directory `/home/travis/build/apache/thrift/lib/c_glib/test'
          make[5]: Entering directory `/home/travis/build/apache/thrift/lib/c_glib/test'
          make  libtestgenc.la libtestgencpp.la testapplicationexception testtransportsocket testbinaryprotocol testbufferedtransport testframedtransport testmemorybuffer teststruct testsimpleserver testdebugproto testoptionalrequired testthrifttest testthrifttestclient
          make[6]: Entering directory `/home/travis/build/apache/thrift/lib/c_glib/test'
          depbase=`echo testapplicationexception.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
          	clang -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src/thrift  -g -Wall -I../src -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include      -MT testapplicationexception.o -MD -MP -MF $depbase.Tpo -c -o testapplicationexception.o testapplicationexception.c &&\
          	mv -f $depbase.Tpo $depbase.Po
          make[6]: *** No rule to make target `../libthrift_c_glib_la-thrift_application_exception.o', needed by `testapplicationexception'.  Stop.
          
          jensg Jens Geyer added a comment - 3 builds failed on Travis , all with the same error: make check-recursive make[4]: Entering directory `/home/travis/build/apache/thrift/lib/c_glib/test' make[5]: Entering directory `/home/travis/build/apache/thrift/lib/c_glib/test' make libtestgenc.la libtestgencpp.la testapplicationexception testtransportsocket testbinaryprotocol testbufferedtransport testframedtransport testmemorybuffer teststruct testsimpleserver testdebugproto testoptionalrequired testthrifttest testthrifttestclient make[6]: Entering directory `/home/travis/build/apache/thrift/lib/c_glib/test' depbase=`echo testapplicationexception.o | sed 's|[^/]*$|.deps/&|;s|\.o$||' `;\ clang -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src/thrift -g -Wall -I../src -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -MT testapplicationexception.o -MD -MP -MF $depbase.Tpo -c -o testapplicationexception.o testapplicationexception.c &&\ mv -f $depbase.Tpo $depbase.Po make[6]: *** No rule to make target `../libthrift_c_glib_la-thrift_application_exception.o ', needed by `testapplicationexception' . Stop.
          simonsouth Simon South added a comment -

          I've attached a third patch that should fix the build issue. This updates the makefile for the C (GLib) unit tests so it refers to the built object files in their new location (now that the subdir-objects option is enabled).

          simonsouth Simon South added a comment - I've attached a third patch that should fix the build issue. This updates the makefile for the C (GLib) unit tests so it refers to the built object files in their new location (now that the subdir-objects option is enabled).
          jensg Jens Geyer added a comment -

          Travis seems to be happy, the only issue is the well-known Haskell OOM.

          jensg Jens Geyer added a comment - Travis seems to be happy, the only issue is the well-known Haskell OOM.
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/thrift/pull/563

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/563
          jensg Jens Geyer added a comment -

          Committed. Thanks, Simon!

          jensg Jens Geyer added a comment - Committed. Thanks, Simon!
          hudson Hudson added a comment -

          SUCCESS: Integrated in Thrift #1625 (See https://builds.apache.org/job/Thrift/1625/)
          THRIFT-2957 warning: source file %s is in a subdirectory, but option 'subdir-objects' is disabled (jensg: rev 8677719180b3ef628122e68c188217d4ba987e40)

          • configure.ac
          • compiler/cpp/Makefile.am
          • lib/c_glib/test/Makefile.am
          hudson Hudson added a comment - SUCCESS: Integrated in Thrift #1625 (See https://builds.apache.org/job/Thrift/1625/ ) THRIFT-2957 warning: source file %s is in a subdirectory, but option 'subdir-objects' is disabled (jensg: rev 8677719180b3ef628122e68c188217d4ba987e40) configure.ac compiler/cpp/Makefile.am lib/c_glib/test/Makefile.am

          People

            simonsouth Simon South
            andrewdeandrade Andrew de Andrade
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: