Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2919

Haxe test server timeout too large

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9.3
    • 0.9.3
    • Test Suite
    • None
    • Patch Available

    Description

      The timeout used to run the Thrift test server is too high. Because the process lives longer than intended, subsequent tests run by make check may be affected as the are not able to bind() the server socket as long as the previous server runs on the same port.

      Attachments

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user Jens-G opened a pull request:

          https://github.com/apache/thrift/pull/340

          THRIFT-2919 Haxe test server timeout too large

          Client: Haxe
          Patch: Jens Geyer

          • reduced timeout and made sure the test script waits appropriately
          • added test to make sure Haxe >= 3.1.3 is used

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Jens-G/thrift thrift-2919

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/thrift/pull/340.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #340


          commit 0bede2fc1266482506c6bd5e75315a06f36ffc56
          Author: Jens Geyer <jensg@apache.org>
          Date: 2014-12-29T18:46:44Z

          THRIFT-2919 Haxe test server timeout too large
          Client: Haxe
          Patch: Jens Geyer

          • reduced timeout and made sure the test script waits appropriately
          • added test to make sure Haxe >= 3.1.3 is used

          githubbot ASF GitHub Bot added a comment - GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/340 THRIFT-2919 Haxe test server timeout too large Client: Haxe Patch: Jens Geyer reduced timeout and made sure the test script waits appropriately added test to make sure Haxe >= 3.1.3 is used You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift thrift-2919 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/340.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #340 commit 0bede2fc1266482506c6bd5e75315a06f36ffc56 Author: Jens Geyer <jensg@apache.org> Date: 2014-12-29T18:46:44Z THRIFT-2919 Haxe test server timeout too large Client: Haxe Patch: Jens Geyer reduced timeout and made sure the test script waits appropriately added test to make sure Haxe >= 3.1.3 is used
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/thrift/pull/340

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/340
          jensg Jens Geyer added a comment -

          Tested & committed

          jensg Jens Geyer added a comment - Tested & committed
          hudson Hudson added a comment -

          SUCCESS: Integrated in Thrift #1418 (See https://builds.apache.org/job/Thrift/1418/)
          THRIFT-2919 Haxe test server timeout too large (jensg: rev 8c8e9c6a555f3b7f57cf1f214242918f2343ebbd)

          • test/haxe/Makefile.am
          • lib/haxe/src/org/apache/thrift/TBase.hx
          hudson Hudson added a comment - SUCCESS: Integrated in Thrift #1418 (See https://builds.apache.org/job/Thrift/1418/ ) THRIFT-2919 Haxe test server timeout too large (jensg: rev 8c8e9c6a555f3b7f57cf1f214242918f2343ebbd) test/haxe/Makefile.am lib/haxe/src/org/apache/thrift/TBase.hx

          People

            jensg Jens Geyer
            jensg Jens Geyer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: