[THRIFT-2886] Integrate binary type in standard Thrift cross test

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: Test Suite
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 11/Dec/14 23:57
• Updated: 20/Dec/15 12:53
• Resolved: 03/Jan/15 16:39

Description

I propose to complete the half-hearted try to integrate the binary type into the test suite. We actually have a CrazyNesting struct defined, yet that structure is not used in any call. So we do test the code generation vis-á-vis compileability, but we do not test whether or not the impleemntation actually works.

Background info: http://stackoverflow.com/questions/27408710/python-thrift-binary-type-requires-encoding

Spec proposal:

  /**
   * Prints 'testBinary("%s")' where '%s' is a hex-formatted string of thing's data
   * @param binary  thing - the binary data to print
   * @return binary  - returns the binary 'thing'
   */
  binary testBinary(1: binary thing),

Test case proposal:
The client sends a binary containing all 256 bytes (in arbitrary order) to the server and checks the returned binary data against the value sent to the server. If they do match exactly, the test counts as passed.

Issue Links

• is related to: THRIFT-3495 Minor enhancements and fixes for cross test