Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1920 Binary Type
  3. THRIFT-2886

Integrate binary type in standard Thrift cross test

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.3
    • Component/s: Test Suite
    • Labels:
      None

      Description

      I propose to complete the half-hearted try to integrate the binary type into the test suite. We actually have a CrazyNesting struct defined, yet that structure is not used in any call. So we do test the code generation vis-รก-vis compileability, but we do not test whether or not the impleemntation actually works.

      Background info: http://stackoverflow.com/questions/27408710/python-thrift-binary-type-requires-encoding

      Spec proposal:

        /**
         * Prints 'testBinary("%s")' where '%s' is a hex-formatted string of thing's data
         * @param binary  thing - the binary data to print
         * @return binary  - returns the binary 'thing'
         */
        binary testBinary(1: binary thing),
      

      Test case proposal:
      The client sends a binary containing all 256 bytes (in arbitrary order) to the server and checks the returned binary data against the value sent to the server. If they do match exactly, the test counts as passed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jensg Jens Geyer
                Reporter:
                jensg Jens Geyer
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: