Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2881

Handle errors from Accept() correctly

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9.2
    • 0.9.3
    • Go - Library
    • Linux Amazon AMI

    • Patch Available

    Description

      Often in tests, servers are started and closed when a test case is finished, as in the standard library's "httptest" package.

      http://golang.org/pkg/net/http/httptest/#example_Server

      However, currently the "p.quit" channel of TSimpleServer does not correctly handle the case when the listener socket is Closed, resulting in spurious logs with the text "Accept err: ...".

      The pull request that fixes this is https://github.com/apache/thrift/pull/309 .

      For details of the discussion behind handling closed listener sockets, please see

      https://code.google.com/p/go/issues/detail?id=4373
      http://zhen.org/blog/graceful-shutdown-of-go-net-dot-listeners/
      http://stackoverflow.com/a/13419724/2182406

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jensg Jens Geyer
            awaw awaw fumin
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment