[THRIFT-2881] Handle errors from Accept() correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: Go - Library
• Labels: patch

Environment

Linux Amazon AMI

• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: awaw fumin
• Created: 08/Dec/14 13:00
• Updated: 29/Dec/14 21:36
• Resolved: 08/Dec/14 20:52

Description

Often in tests, servers are started and closed when a test case is finished, as in the standard library's "httptest" package.

http://golang.org/pkg/net/http/httptest/#example_Server

However, currently the "p.quit" channel of TSimpleServer does not correctly handle the case when the listener socket is Closed, resulting in spurious logs with the text "Accept err: ...".

The pull request that fixes this is https://github.com/apache/thrift/pull/309 .

For details of the discussion behind handling closed listener sockets, please see

https://code.google.com/p/go/issues/detail?id=4373
http://zhen.org/blog/graceful-shutdown-of-go-net-dot-listeners/
http://stackoverflow.com/a/13419724/2182406