[THRIFT-2868] Enhance error handling in the Go client

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: Go - Compiler, Go - Library
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Chi Vinh Le
• Created: 01/Dec/14 20:32
• Updated: 29/Dec/14 21:36
• Resolved: 08/Dec/14 20:52

Description

The Go client doesn't do proper error checking. E.g. it doesn't check whether the received method name is correct nor if the message type has the expected value.

The following PR enhances the Go client error handling by the following:

• Check if method name is correct -> if not return thrift.WRONG_METHOD_NAME
• Check if MessageType is thrift.REPLY or EXCEPTION -> if not return thrift.INVALID_MESSAGE_TYPE_EXCEPTION
• Checking the sequence id is done before checking the message type

Includes test cases for every error case.

https://github.com/apache/thrift/pull/297

Issue Links

• contains: THRIFT-2865 Test case for Go: SeqId out of sequence