Details
-
New Feature
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
Description
It is a follow-up for discussion with Facebook's fbthrift https://github.com/facebook/fbthrift/issues/48
fbthrift adds its own generator that creates C++ classes based on their libraries. I do not know how upstreamable this generator but I think other companies would want to do the same - create their own custom generators.
Currently there is no way to distribute generators separately from the thrift core. Thus the company have to fork whole project and add their own generator. It is what Facebook did.
The idea is that thrift should be able to load language generators dynamically. i.e. a company foo creates its own generator and puts it to system /usr/lib/thrift/generators/cpp_foo.so When thrift compiler starts - it checks /usr/lib/thrift/generators/ and uses dlopen() to load the shared libraries. The shared library contains information about the generator (name, options, ...) thus it allows thrift core to use this custom third-party generator.
This allows companies to create and distribute generator will less pain and no need to fork the project.
Attachments
Issue Links
- breaks
-
THRIFT-3949 missing make dist entry for compiler/cpp/test
-
- Closed
-
-
-
- Closed
-
- is a parent of
-
THRIFT-4401
document compiler plugin feature on the web site
-
- Closed
-
- is related to
-
THRIFT-4743 Remove the compiler plug-in mode
-
- Closed
-
- links to
