Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2724 Coding standards page
  3. THRIFT-2807

PHP Code Style

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.9.3
    • PHP - Library
    • None

    Description

      The Code Style of the PHP Library is seemingly non-consitent (depending on who's been writing it).
      I've proposed a PR (https://github.com/apache/thrift/pull/252) that runs a simple php-cs-fixer across the library to amend code style (tabs, bracket alignment etc).

      The Travis build has executed and passed.

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-2724 Coding standards page

          • Major - Major loss of function.
          • Open
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-4460 php library use PSR-2

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              roger Roger Meier
              rogere84 Roger Thomas
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: