Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
None
-
Patch Available
Description
GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/246
Wrap errors in iostream_transport.go
When I used the StreamTransport to do unit tests I noticed that the EOF TTransportException is not correctly thrown. I quickly found out that the errors in iostream_transport.go where not wrapped with
NewTTransportExceptionFromError. Fixed that quickly and it works greatly!
Hope this saves others precious time when developing with thrift and go
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvlchinet/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #246
commit c00fa154faa337db47a07c2c49d13d51c487d77a
Author: cvlchinet <cvl@chinet.info>
Date: 2014-10-11T22:57:23Z
Wrap errors in iostream_transport.go
Wrap errors in iostream_transport.go using NewTTransportExceptionFromError