Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-276

Ruby libraries should have one class per file

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.1
    • Fix Version/s: 0.1
    • Component/s: Ruby - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      There's no reason for so many of our classes to be lumped into the same file. For instance, transport.rb contains 9 classes. They may be short, but organizationally, it's superior to have separate class files. Of course, some files may contain more than one class per file as appropriate - things like a protocol and its factory, for instance, are perfectly acceptable to group.

        Attachments

        1. thrift-276-v8.patch
          230 kB
          Michael Stockton
        2. thrift-276-v7.patch
          228 kB
          Michael Stockton
        3. thrift-276-v6.patch
          226 kB
          Michael Stockton
        4. thrift-276-v5.patch
          200 kB
          Michael Stockton
        5. thrift-276-v4.patch
          237 kB
          Michael Stockton
        6. thrift-276-v3.patch
          212 kB
          Michael Stockton
        7. thrift-276-v2.patch
          209 kB
          Michael Stockton
        8. thrift-276.patch
          208 kB
          Michael Stockton

          Issue Links

            Activity

              People

              • Assignee:
                michaelstockton Michael Stockton
                Reporter:
                bryanduxbury Bryan Duxbury
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: