[THRIFT-2689] struct names that differ only in capitalization of first character generate broken erlang code

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Component/s: Erlang - Compiler, Erlang - Library
• Patch Info: Patch Available
• Assignee: alisdair sullivan
• Reporter: alisdair sullivan
• Created: 02/Sep/14 23:26
• Updated: 05/Nov/14 04:49
• Resolved: 07/Oct/14 19:20

Description

the following thrift specification generates broken erlang code:

struct invalid

{ /* contents of struct are irrelevent */ }

struct Invalid

{ /* still irrelevent }

the compiler currently renames any struct that starts with a capital so that it starts with a lowercase letter. instead, it should leave names intact and use proper erlang syntax in generation. the attached patch does exactly that

this does break backwards compatibility