[THRIFT-2683] c_glib: Seg fault when deserializing a map with typedef'd keys

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Component/s: C glib - Compiler
• Labels: c_glib compiler

Environment

Fedora 20 64-bit on x86_64

• Patch Info: Patch Available
• Assignee: Simon South
• Reporter: Simon South
• Created: 31/Aug/14 03:27
• Updated: 05/Nov/14 04:49
• Resolved: 01/Sep/14 18:24

Description

In the c_glib implementation, attempting to deserialize a map that uses a typedef'd type for its keys will usually result in a segmentation fault.

This is because the code in the compiler that generates a variable declaration for a pointer to key values fails to first resolve the typedef to its underlying type. In most cases it will therefore generate incorrect code, effectively allocating a variable on the stack but later using it as though it were a pointer.

The attached patch fixes this. (No test case is provided, but the integration test implementation I'm about to submit relies on this patch.)

Issue Links

• is required by: THRIFT-2685 c_glib: Include in integration test suite