Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2677

Haskell library needs to build with network >= 2.6

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.2
    • Component/s: Haskell - Library, Tutorial
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Some recent changes in the network library for Haskell require conditional compilation, both the haskell tutorial and library need to be updated to take this into account. Description of the solution is on network's hackage page: http://hackage.haskell.org/package/network-2.6.0.1

      Travis fails with:

      src/Thrift/Transport/HttpClient.hs:29:8:
      
      Could not find module ‘Network.URI’
      
      It is a member of the hidden package ‘network-uri-2.6.0.0’.
      
      Perhaps you need to add ‘network-uri’ to the build-depends in your .cabal file.
      
      Use -v to see a list of the files searched for.
      
      cabal: Error: some packages failed to install:
      
      thrift-1.0.0 failed during the building phase. The exception was:
      
      ExitFailure 1
      

      Travis run with this patch applied: https://travis-ci.org/cheecheeo/thrift/builds/33556425

      Tutorial successfully compiles:

      % cabal --sandbox-config-file=../../cabal.sandbox.config install                                                                                                                                                   ±  ⃠
      Resolving dependencies...
      Configuring ThriftTutorial-0.1.0...
      Building ThriftTutorial-0.1.0...
      Preprocessing executable 'HaskellServer' for ThriftTutorial-0.1.0...
      [1 of 7] Compiling Shared_Types     ( gen-hs/Shared_Types.hs, dist/dist-sandbox-ca46c903/build/HaskellServer/HaskellServer-tmp/Shared_Types.o )
      [2 of 7] Compiling SharedService_Iface ( gen-hs/SharedService_Iface.hs, dist/dist-sandbox-ca46c903/build/HaskellServer/HaskellServer-tmp/SharedService_Iface.o )
      [3 of 7] Compiling SharedService    ( gen-hs/SharedService.hs, dist/dist-sandbox-ca46c903/build/HaskellServer/HaskellServer-tmp/SharedService.o )
      [4 of 7] Compiling Tutorial_Types   ( gen-hs/Tutorial_Types.hs, dist/dist-sandbox-ca46c903/build/HaskellServer/HaskellServer-tmp/Tutorial_Types.o )
      [5 of 7] Compiling Calculator_Iface ( gen-hs/Calculator_Iface.hs, dist/dist-sandbox-ca46c903/build/HaskellServer/HaskellServer-tmp/Calculator_Iface.o )
      [6 of 7] Compiling Calculator       ( gen-hs/Calculator.hs, dist/dist-sandbox-ca46c903/build/HaskellServer/HaskellServer-tmp/Calculator.o )
      [7 of 7] Compiling Main             ( HaskellServer.hs, dist/dist-sandbox-ca46c903/build/HaskellServer/HaskellServer-tmp/Main.o )
      Linking dist/dist-sandbox-ca46c903/build/HaskellServer/HaskellServer ...
      Preprocessing executable 'HaskellClient' for ThriftTutorial-0.1.0...
      [1 of 9] Compiling Shared_Types     ( gen-hs/Shared_Types.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/Shared_Types.o )
      [2 of 9] Compiling SharedService_Iface ( gen-hs/SharedService_Iface.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/SharedService_Iface.o )
      [3 of 9] Compiling SharedService    ( gen-hs/SharedService.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/SharedService.o )
      [4 of 9] Compiling Tutorial_Types   ( gen-hs/Tutorial_Types.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/Tutorial_Types.o )
      [5 of 9] Compiling Calculator_Iface ( gen-hs/Calculator_Iface.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/Calculator_Iface.o )
      [6 of 9] Compiling SharedService_Client ( gen-hs/SharedService_Client.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/SharedService_Client.o )
      [7 of 9] Compiling Calculator       ( gen-hs/Calculator.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/Calculator.o )
      [8 of 9] Compiling Calculator_Client ( gen-hs/Calculator_Client.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/Calculator_Client.o )
      [9 of 9] Compiling Main             ( HaskellClient.hs, dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient-tmp/Main.o )
      Linking dist/dist-sandbox-ca46c903/build/HaskellClient/HaskellClient ...
      Installing executable(s) in /home/jchee/packages/thrift/.cabal-sandbox/bin
      Installed ThriftTutorial-0.1.0
      

      cc: [~roger.meier]

        Attachments

          Activity

            People

            • Assignee:
              roger Roger Meier
              Reporter:
              cheecheeo John Chee
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: