Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2666

Usage of PYTHONHASHSEED breaks older Python code

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9.2
    • 0.9.2
    • Python - Compiler
    • None

    Description

      The hash function introduced with THRIFT-2621 breaks with Python older than 3.2, because PYTHONHASHSEED has been introduced with 3.2.

      The proposed solution is to define a constant PYTHONHASHSEED as a workaround, but only if PYTHONHASHSEED is not available.

      Attachments

        1. THRIFT-2666.patch
          0.8 kB
          Jens Geyer

        Issue Links

          Activity

            jensg Jens Geyer added a comment - - edited

            Replaced PYTHONHASHSEED by a literal. Any better solution is welcome.

            jensg Jens Geyer added a comment - - edited Replaced PYTHONHASHSEED by a literal. Any better solution is welcome.
            jensg Jens Geyer added a comment -

            Committed.

            jensg Jens Geyer added a comment - Committed.
            hudson Hudson added a comment -

            SUCCESS: Integrated in Thrift #1269 (See https://builds.apache.org/job/Thrift/1269/)
            THRIFT-2666 Usage of PYTHONHASHSEED breaks older Python code (jensg: rev d0bd17e7263cb8f92c21d3e1dad2ee5b5e9f79e5)

            • compiler/cpp/src/generate/t_py_generator.cc
            hudson Hudson added a comment - SUCCESS: Integrated in Thrift #1269 (See https://builds.apache.org/job/Thrift/1269/ ) THRIFT-2666 Usage of PYTHONHASHSEED breaks older Python code (jensg: rev d0bd17e7263cb8f92c21d3e1dad2ee5b5e9f79e5) compiler/cpp/src/generate/t_py_generator.cc
            hudson Hudson added a comment -

            FAILURE: Integrated in Thrift-Test #17 (See https://builds.apache.org/job/Thrift-Test/17/)
            THRIFT-2666 Usage of PYTHONHASHSEED breaks older Python code (jensg: rev d0bd17e7263cb8f92c21d3e1dad2ee5b5e9f79e5)

            • compiler/cpp/src/generate/t_py_generator.cc
            hudson Hudson added a comment - FAILURE: Integrated in Thrift-Test #17 (See https://builds.apache.org/job/Thrift-Test/17/ ) THRIFT-2666 Usage of PYTHONHASHSEED breaks older Python code (jensg: rev d0bd17e7263cb8f92c21d3e1dad2ee5b5e9f79e5) compiler/cpp/src/generate/t_py_generator.cc
            hudson Hudson added a comment -

            SUCCESS: Integrated in Thrift #1331 (See https://builds.apache.org/job/Thrift/1331/)
            THRIFT-2666 Usage of PYTHONHASHSEED breaks older Python code (jensg: rev d0bd17e7263cb8f92c21d3e1dad2ee5b5e9f79e5)

            • compiler/cpp/src/generate/t_py_generator.cc
            hudson Hudson added a comment - SUCCESS: Integrated in Thrift #1331 (See https://builds.apache.org/job/Thrift/1331/ ) THRIFT-2666 Usage of PYTHONHASHSEED breaks older Python code (jensg: rev d0bd17e7263cb8f92c21d3e1dad2ee5b5e9f79e5) compiler/cpp/src/generate/t_py_generator.cc

            People

              jensg Jens Geyer
              jensg Jens Geyer
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: