Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2630

windows7 64bit pc. ipv4 and ipv6 pc.can't use

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • 0.9.1
    • 0.9.3
    • C++ - Library
    • None
    • windows7 64bit pc. ipv4 and ipv6 pc.can't use

    • Patch Available

    Description

      net error no : 10093

      Attachments

        1. TServerSocket.cpp
          17 kB
          alan

        Issue Links

          Activity

            jrckkyy alan added a comment -

            how can i commit patch?

            I fix this bug.

            TServerSocket.cpp update some code。
            at void TServerSocket::listen() add code:
            // init Winsock add by alan 20140719
            WSADATA wsaData;
            int nStatus = WSAStartup(MAKEWORD(2,2), &wsaData);
            if (NO_ERROR != nStatus)

            { printf("WSAStartup() error\n"); }

            and
            hints.ai_family = PF_UNSPEC;
            update to:
            hints.ai_family = AF_INET; // add by alan 20140719

            jrckkyy alan added a comment - how can i commit patch? I fix this bug. TServerSocket.cpp update some code。 at void TServerSocket::listen() add code: // init Winsock add by alan 20140719 WSADATA wsaData; int nStatus = WSAStartup(MAKEWORD(2,2), &wsaData); if (NO_ERROR != nStatus) { printf("WSAStartup() error\n"); } and hints.ai_family = PF_UNSPEC; update to: hints.ai_family = AF_INET; // add by alan 20140719
            jensg Jens Geyer added a comment - - edited

            Hi jrckkyy,

            how can i commit patch?

            Please add the patch file to this ticket (via More /Add Files). If you have an appropriate test case, please add it too. Details about how the process works can be found here.

            jensg Jens Geyer added a comment - - edited Hi jrckkyy , how can i commit patch? Please add the patch file to this ticket (via More /Add Files). If you have an appropriate test case, please add it too. Details about how the process works can be found here .
            jrckkyy alan added a comment -

            change at 157line and 179line

            jrckkyy alan added a comment - change at 157line and 179line
            jensg Jens Geyer added a comment -

            I just compared the file you added against trunk and there are a lot more differences that just two lines. Could you please try to create a patch file from your changes? If that's too complicated, consider opening a Github pull request instead and mention the ticket THRIFT-2630 in the comment.

            jensg Jens Geyer added a comment - I just compared the file you added against trunk and there are a lot more differences that just two lines. Could you please try to create a patch file from your changes? If that's too complicated, consider opening a Github pull request instead and mention the ticket THRIFT-2630 in the comment.

            The winsock initialization was added since this was posted as part of THRIFT-2442.

            The documentation for getaddrinfo from Microsoft states that =PF_UNSPEC is the correct value to support either IPv4 or IPv6. As such, there is nothing else to do for this ticket, so I am resolving it as a duplicate of THRIFT-2442.

            jking3 James E. King III added a comment - The winsock initialization was added since this was posted as part of THRIFT-2442 . The documentation for getaddrinfo from Microsoft states that =PF_UNSPEC is the correct value to support either IPv4 or IPv6. As such, there is nothing else to do for this ticket, so I am resolving it as a duplicate of THRIFT-2442 .

            It was actually fixed in 0.9.2, but if you want to put it into any release notes for 0.9.3, I assume that's why you changed it?

            jking3 James E. King III added a comment - It was actually fixed in 0.9.2, but if you want to put it into any release notes for 0.9.3, I assume that's why you changed it?

            People

              jking3 James E. King III
              jrckkyy alan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: