[THRIFT-2554] double initialization in generated Read() method

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Component/s: C# - Compiler
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 28/May/14 21:25
• Updated: 30/May/14 16:27
• Resolved: 30/May/14 15:55

Description

IDL

struct Element {
	1: string foobar
}

struct Test {
	1: list<Element>  elms
}

produces this code:

Test.cs

public partial class Test : TBase
{
  //... stuff ...

  public void Read (TProtocol iprot)
  {
    //... stuff ...
        case 1:
          if (field.Type == TType.List) {
            {
              Elms = new List<Element>();
              TList _list0 = iprot.ReadListBegin();
              for( int _i1 = 0; _i1 < _list0.Count; ++_i1)
              {
                Element _elem2 = new Element();    // <-- first instance
                _elem2 = new Element();            // <-- second instance
                _elem2.Read(iprot);
                Elms.Add(_elem2);
              }
              iprot.ReadListEnd();
            }
      //... more stuff ...
}