[THRIFT-2465] TBinaryProtocolT breaks if copied/moved

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.9
• Fix Version/s: 0.9.3
• Component/s: C++ - Library
• Assignee: Konrad Grochowski
• Reporter: Vitali Lovich
• Created: 13/Apr/14 23:44
• Updated: 26/Jan/15 02:26
• Resolved: 04/Dec/14 21:38

Description

by virtue of omitting the copy constructor, TBinaryProtocolT gets a default one generated for it which is incorrect since it's potentially managing memory (namely the string_buf_ pointer).

TBinaryProtocolT should delete/make private the copy constructor & copy assignment operator.

Under C+11, string_buf_ could be changed to a unique_ptr which would let you use the default move constructor/move assignment operator. Alternatively under C+11, a move constructor/assignment operator needs to be defined.