[THRIFT-2462] prevent possible stack overflow due to recursive syntax support

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.9.2
• Component/s: C# - Compiler, Delphi - Compiler
• Labels: graph
• Assignee: Unassigned
• Reporter: Jens Geyer
• Created: 12/Apr/14 22:48
• Updated: 12/Apr/14 22:50

Description

Test.Thrift

namespace * Thrift.Test

struct Foo {
  1: Bar bar
}

struct Bar {
  1: Foo foo 
}

service ThriftTest
{
  i32 testRecursive(1: Foo foo);
}

TestClient.cs

var first = new Foo()
{
	Bar = new Bar()
	{
		Foo = new Foo()
		{
			Bar = new Bar()
			{
				Foo = null
			}
		}
	}
};

Console.Write("testRecursive(tree)");
Console.WriteLine(" = {0}", client.testRecursive(first));


Console.Write("testRecursive(ring)");
first.Bar.Foo.Bar.Foo = first;  // now let the innermost leaf backpoint to the root node
Console.WriteLine(" = {0}", client.testRecursive(first));

output

testRecursive(tree) = 4
testRecursive(ring)
Process is terminated due to StackOverflowException.

Issue Links

• depends upon: THRIFT-2421 Tree/Recursive struct support in thrift