[THRIFT-2390] no close event when connection lost

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Component/s: Node.js - Library
• Assignee: Jake Farrell
• Reporter: alexey
• Created: 06/Mar/14 12:24
• Updated: 10/Jul/14 13:42
• Resolved: 10/Jul/14 13:42

Description

thrift nodejs lib (master)

There is no indication that connection lost if reconnect is not setup.
(There is no "close" event from connection object or RPC error callback)

File: connection.js:167

Connection.prototype.connection_gone = function () {
var self = this;

// If a retry is already in progress, just let that happen
if (this.retry_timer || !this.max_attempts)

{ return; }


Should be changed to

Connection.prototype.connection_gone = function () {
var self = this;

// If a retry is already in progress, just let that happen
if (this.retry_timer) { return; }

if(!this.max_attempts)

{ self.emit("close"); return; }