[THRIFT-2375] Excessive <br>'s in generated HTML

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Component/s: HTML - Compiler
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Nevo Hed
• Created: 23/Feb/14 02:53
• Updated: 01/Apr/14 20:01
• Resolved: 11/Mar/14 20:33

Description

This was working "right" (at least how I thought it should work) back in 0.9.0 going back at least to 0.7.0 and introduced in 0.9.1
https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=commit;h=63e3c63

The issue is that there is a '<br>' in HTML after every newline in the source comment (thrift). I assume that this was not the intention of the THRIFT-1800 change.

I will attach complete sample thrift files and html output, but here is a summary:

This is what the output USED to look like

<tr><td>1</td><td>theThing</td><td><code>i32</code></td><td>Some comments can go for quite a while and may span multiple
lines. What looks like a good spot to break a line in the
thrift file may turn out to be not so great in HTML. In
fact in HTML we should let the browser decide when to start
a new lines. Users can still
insert a break<br> when they really need/want it
</td><td>required</td><td></td></tr>
</table><br/></div></div></body></html>

And this is what it looks like today

<tr><td>1</td><td>theThing</td><td><code>i32</code></td><td>Some comments can go for quite a while and may span multiple<br/>lines. What looks like a good spot to break a li
ne in the<br/>thrift file may turn out to be not so great in HTML. In<br/>fact in HTML we should let the browser decide when to start<br/>a new lines. Users can still<br/>
insert a break<br> when they really need/want it<br/></td><td>required</td><td></td></tr>
</table><br/></div></div></body></html>