Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2372

thrift/json_protocol.go:160: function ends without a return statement

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9.2
    • 0.9.2
    • Go - Library
    • None

    Description

      missing return statement at end of function (in if/else block)

      Attachments

        Activity

          jfarrell Jake Farrell added a comment -

          committed 3fa14a3

          jfarrell Jake Farrell added a comment - committed 3fa14a3
          hudson Hudson added a comment -

          FAILURE: Integrated in Thrift #1054 (See https://builds.apache.org/job/Thrift/1054/)
          THRIFT-2372:thrift/json_protocol.go:160: function ends without a return statement (jfarrell: rev 3fa14a3990e973f0354059191bec34dcc8184af8)

          • lib/go/thrift/json_protocol.go
          hudson Hudson added a comment - FAILURE: Integrated in Thrift #1054 (See https://builds.apache.org/job/Thrift/1054/ ) THRIFT-2372 :thrift/json_protocol.go:160: function ends without a return statement (jfarrell: rev 3fa14a3990e973f0354059191bec34dcc8184af8) lib/go/thrift/json_protocol.go
          jensg Jens Geyer added a comment -

          Is that a compiler bug? I didn't get that error, interestingly.

          jensg Jens Geyer added a comment - Is that a compiler bug? I didn't get that error, interestingly.
          jfarrell Jake Farrell added a comment -

          Was testing the vagrant image and got this error, what I committed fixed the issue for me within the test vm

          root@vagrant-ubuntu-precise-64:/thrift# go version
          go version go1

          Making all in go
          make[3]: Entering directory `/thrift/lib/go'
          Making all in test
          make[4]: Entering directory `/thrift/lib/go/test'
          make[4]: Nothing to be done for `all'.
          make[4]: Leaving directory `/thrift/lib/go/test'
          make[4]: Entering directory `/thrift/lib/go'
          /usr/bin/go test ./thrift
          # _/thrift/lib/go/thrift
          thrift/json_protocol.go:160: function ends without a return statement
          FAIL	_/thrift/lib/go/thrift [build failed]
          make[4]: *** [check-local] Error 2
          make[4]: Leaving directory `/thrift/lib/go'
          make[3]: *** [all-recursive] Error 1
          make[3]: Leaving directory `/thrift/lib/go'
          make[2]: *** [all-recursive] Error 1
          make[2]: Leaving directory `/thrift/lib'
          make[1]: *** [all-recursive] Error 1
          make[1]: Leaving directory `/thrift'
          make: *** [all] Error 2
          
          jfarrell Jake Farrell added a comment - Was testing the vagrant image and got this error, what I committed fixed the issue for me within the test vm root@vagrant-ubuntu-precise-64:/thrift# go version go version go1 Making all in go make[3]: Entering directory `/thrift/lib/go' Making all in test make[4]: Entering directory `/thrift/lib/go/test' make[4]: Nothing to be done for `all'. make[4]: Leaving directory `/thrift/lib/go/test' make[4]: Entering directory `/thrift/lib/go' /usr/bin/go test ./thrift # _/thrift/lib/go/thrift thrift/json_protocol.go:160: function ends without a return statement FAIL _/thrift/lib/go/thrift [build failed] make[4]: *** [check-local] Error 2 make[4]: Leaving directory `/thrift/lib/go' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/thrift/lib/go' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/thrift/lib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/thrift' make: *** [all] Error 2

          People

            jfarrell Jake Farrell
            jfarrell Jake Farrell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: