[THRIFT-2357] recurse option has no effect when generating php

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Assignee: Unassigned
• Reporter: Mark Manashirov
• Created: 11/Feb/14 16:41
• Updated: 02/Dec/16 01:03
• Resolved: 10/Jul/14 13:42

Description

When compiling a thrift file that includes other thrift files the included files does not get generated for php.

For example:

foo.thrift:
--------------------------------------------------------
include "bar.thrift"
service FooService {
bar.Foo SeeDosRun(1: bar.Baz baz);
}

bar.thrift
--------------------------------------------------------
struct Foo {
1: string foo;
}
struct Baz {
1: string baz;
}

thrift -v --gen php -r foo.thrift
Scanning /home/mmanashirov/CMS/develop/tmp/foo.thrift for includes
Scanning /home/mmanashirov/CMS/develop/tmp/bar.thrift for includes
Parsing /home/mmanashirov/CMS/develop/tmp/bar.thrift for types
Parsing /home/mmanashirov/CMS/develop/tmp/foo.thrift for types
Program: /home/mmanashirov/CMS/develop/tmp/bar.thrift
Generating "php"
Program: /home/mmanashirov/CMS/develop/tmp/foo.thrift
Generating "php"

It says generating php after bar.thrift but no files actually get generated for that file. On the other hand generating files for cpp, py, js for example all work.