[THRIFT-2352] msvc failed to compile thrift tests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Component/s: C++ - Library
• Labels: build patch test

Environment

Windows7/Visual Studio 2012

• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Sergei Nikulov
• Created: 06/Feb/14 19:43
• Updated: 20/Feb/21 15:28
• Resolved: 09/Feb/14 10:32

Description

Patch related to THRIFT-2029 and fixes two test compilation issues with msvc.

1. Renamed small to tiny in test/DebugProtoTest.thrift
Rationale: generated code contains bool small; which is conflicted with macro definition picked up from windows.h > rpcndr.h > "#define small char" (refer to http://connect.microsoft.com/VisualStudio/feedback/details/775845/poorly-picked-names-in-rpcndr-h-have-a-high-chance-of-collision and http://stackoverflow.com/questions/21165891/is-small-a-keyword-in-c and http://code.opencv.org/issues/1041)

2. Use THRIFT_GETTIMEOFDAY instead of gettimeofday in lib/cpp/test/Benchmark.cpp because of absence of latter on Windows