[THRIFT-2351] PHP TCompactProtocol has fails to decode messages

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Component/s: PHP - Library
• Labels: easyfix

Environment

Tested under PHP 5.3 and HHVM latest.

• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Paul Banks
• Created: 06/Feb/14 18:00
• Updated: 29/Jun/15 21:32
• Resolved: 10/Jul/14 13:42

Description

There are two typos in TCompactProtocol::readMessageBegin that prevent correct decoding of any message. They are on consecutive lines:

https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Protocol/TCompactProtocol.php#L390-L391

First $seqId does not match case of argument $seqid so this is not set PHP is not case sensitive for class names but IS for variable names.

Second and more importantly, on the following line $name has the decoded length assigned to it instead of $result. This means the method name "hello" ends up being decoded as "6" (the length of the string plus length prefix) and hence any processor trying to dispatch the event will fail.

I can submit a patch/pull request but its only 6 chars to change and clearly there are no automated tests for this protocol implementation as that should have been caught before.

I guess not many other people are using PHP as a thrift service processor with this protocol.

Issue Links

• is related to: THRIFT-2358 C++: add compact protocol to cross language test suite
• relates to: THRIFT-3211 Add make cross support for php TCompactProtocol
• supercedes: THRIFT-334 Compact Protocol for PHP