[THRIFT-2342] Add __FILE__ and __LINE__ to Thrift C++ excpetions

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Fix Version/s: 0.10.0
• Component/s: C++ - Compiler, C++ - Library
• Labels: newbie
• Assignee: James E. King III
• Reporter: George Godik
• Created: 01/Feb/14 17:48
• Updated: 12/May/17 22:11
• Resolved: 04/Apr/16 19:34

Description

Thrift exceptions are somewhat difficult to trace from debug logs. I'd like to add _FILEANDLINE_ as a second parameter to some exceptions to make them easier to find.

For example:

Every time a required field is not set, the exception that gets generated is a very generic
throw TProtocolException(TProtocolException::INVALID_DATA)

see - https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372

I think I'll start with patching up TProtocolExcpetion in the compiler and if people like this I can make a separate issue and patch for other exceptions

Issue Links

• is cloned by: THRIFT-3363 Reporting a missing required field (TProtocolException::INVALID_DATA) to the client is not informative enough
• is cloned by: THRIFT-4198 Ruby should log Thrift internal errors to global logger