[THRIFT-2311] Go: invalid code generated when exception name is a go keyword

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Component/s: Go - Compiler
• Labels: reserved-word

Environment

All platforms

• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Krzysztof Godlewski
• Created: 12/Jan/14 19:47
• Updated: 15/Jan/14 02:59
• Resolved: 13/Jan/14 18:57

Description

Go code generator emits invalid code when a service method is declared to throw an exception, which name is a Go keyword.

To reproduce, create gobug.thrift:

gobug.thrift

exception FooError { }

service Foo {
        void bar() throws (1: FooError error)
}

Run:

thrift -gen go gobug.thrift && (cd gen-go/gobug && go build -a)

This should result in the following error:

./foo.go:106: result1.Error undefined (type *BarResult has no field or method Error)
./foo.go:107: type error is not an expression
./foo.go:107: cannot assign to <nil>.error
./foo.go:107: result1.Error undefined (type *BarResult has no field or method Error)