[THRIFT-2304] Move client assignments from construtor in method

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Component/s: C++ - Compiler
• Assignee: Roger Meier
• Reporter: Martin Vogt
• Created: 31/Dec/13 17:40
• Updated: 15/Jan/14 02:59
• Resolved: 04/Jan/14 22:33

Description

The current generated client code in C++ look like this
(namespace removed, for better formatting):

class MyServiceClient : virtual public MyServiceIf {
 public:
  MyServiceClient(shared_ptr< TProtocol> prot) :
    piprot_(prot),
    poprot_(prot) {
    iprot_ = prot.get();
    oprot_ = prot.get();
  }
 [...]

The member variables are assigned in the constructor.
The patch puts the assignment into its own method:

class MyServiceClient : virtual public MyServiceIf {
 public:
  MyServiceClient(shared_ptr< TProtocol> prot) {
    setProtocol(prot);
  }
  [..]
private:
  void setProtocol(shared_ptr< TProtocol> prot) {
     setProtocol(prot,prot);
  }
 void setProtocol(shared<:TProtocol> iprot,shared_ptr<TProtocol> oprot) {
    piprot_=iprot;
    poprot_=oprot;
    iprot_ = iprot.get();
    oprot_ = oprot.get();
  }

This allows to change the TProtocol instance, after the Client creation. (With removing the private field or using a virtual method in a Service base class)