[THRIFT-2274] TNonblockingServer and TThreadedSelectorServer do not close their channel selectors on exit and leak file descriptors

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Component/s: Java - Library
• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Thomas Kielbus
• Created: 27/Nov/13 00:49
• Updated: 18/Mar/15 20:34
• Resolved: 08/Dec/13 20:01

Description

TNonblockingServer and TThreadedSelectorServer do not close their channel selectors on exit and do not release all ressources.

This is an issue especially when such server implementations are started and stopped repeatedly within the same JVM. In our use case, we see hundreds of file descriptors being leaked on each Thrift server restart. We hit the OS limit on the number of open files pretty quickly.

The attached patch fixes the issue by simply calling Selector.close() when the relevant select threads exit (TNonBlockingServer::SelectAcceptThread, TThreadedSelectorServer::SelectorThread, TThreadedSelectorServer::AcceptThread)

Issue Links

• is duplicated by: THRIFT-2302 TNonblockingServer is not closing selector