Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-226

Collections with binary keys or values break equals()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.4
    • Java - Compiler
    • None

    Description

      In Java, byte[].equals tests object equality, not value equality. As a result, if you have two list<binary> (or set<binary>, or map<binary, binary> with the same values and you do TBase.equals(), two structs that match by value won't return true. If we're going to do value equality, which I think we should, then we should make this consistent with collection types.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-783 .equals java method is broken on structs containing binary-type fields

          • Major - Major loss of function.
          • Closed
          is part of

          Sub-task - The sub-task of the issue THRIFT-830 Switch binary field implementation from byte[] to ByteBuffer

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-135 Nulls in set<string> throw an exception in Java

          • Major - Major loss of function.
          • Closed

          Activity

            People

              bryanduxbury Bryan Duxbury
              bryanduxbury Bryan Duxbury
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: