[THRIFT-2210] lib/java TSimpleJSONProtocol can emit invalid JSON

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Patch Info: Patch Available
• Assignee: Alex Levenson
• Reporter: Alex Levenson
• Created: 26/Sep/13 06:37
• Updated: 06/Mar/16 17:25
• Resolved: 27/Sep/13 14:13

Description

TSimpleJSONProtocol can emit JSON with maps whose keys are not string (which is not allowed is the JSON spec).

This happens if the key in a map is anything other than a String (int, enum, etc)

For example, it can emit JSON like this:

{"myMap":{5:"myValue"}}

which should be:

{"myMap":{"5":"myValue"}}

I have a path that fixes this, I'll upload it shortly (still trying to get my dev environment to run the tests).

Also AFAICT there is no unit test for TSimpleJSONProtocol – I'll try and add one to the patch.

Thanks!
Alex