Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2166

Delphi compiler should generate constant class name prefixed with thrift file name (similar to Java and C#)

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • Delphi - Compiler
    • None
    • Patch Available

    Description

      Similar to Java and C#, the Delphi compiler should generate constant class name prefixed with thrift file Name:

      Example:

      TIncludesTestConstants

      instead of just

      TConstants

      .

      This makes it easier to distinguish between different constants when two or more generated Delphi units are used from the same source file without the need to add (possibly lengthy) prefixes.

      Attachments

        Activity

          hudson Hudson added a comment -

          SUCCESS: Integrated in Thrift #888 (See https://builds.apache.org/job/Thrift/888/)
          THRIFT-2166 Delphi compiler should generate constant class name prefixed with thrift file name (similar to Java and C#) (jensg: rev ec8744c4dd84f8077a590cdcbb58a921cec1d14c)

          • compiler/cpp/src/generate/t_delphi_generator.cc
          hudson Hudson added a comment - SUCCESS: Integrated in Thrift #888 (See https://builds.apache.org/job/Thrift/888/ ) THRIFT-2166 Delphi compiler should generate constant class name prefixed with thrift file name (similar to Java and C#) (jensg: rev ec8744c4dd84f8077a590cdcbb58a921cec1d14c) compiler/cpp/src/generate/t_delphi_generator.cc
          jensg Jens Geyer added a comment -

          Committed.

          The new behaviour can be enabled by specifying the new delphi:constprefix switch.

          jensg Jens Geyer added a comment - Committed. The new behaviour can be enabled by specifying the new delphi:constprefix switch.

          People

            jensg Jens Geyer
            jensg Jens Geyer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: